Flow123d  JS_before_hm-62-ge56f9d5
Todo List
File distribution.hh
  • need better resolution of constructors
File field_algo_base.hh
  • better tests:
    • common set of quantities with different kind of values (scalar, vector, tensor, discrete, ..), common points and elements for evaluation
    • for individual Field implementations have:
      • different input
      • possibly different EPETCT_EQ tests, but rather have majority common
File field_python.hh
make FieldPython dummy class if we do not have python, so that we need not optional code elsewhere
File input_type.hh
  • explicit instantiation of templates in accessors - not so easy
File ref_element.hh
File region.hh
  • komentar k RegionIdx
  • presun enum RegionType do public Region - komentar + pouzit v kodu
  • zkontrolovat chybove hlasky a ASSERTY, co z toho by melo byt pres exception?
File schur.cc
  • vyresit navaznost na lin sys - solve a export seq vektoru, redukce ... ?
  • inv_a - predava se pri konstrukci, ale neumoznuje jeji reuse - aktualizaci assemblace resp. nutno si na ni drzet ukazatel venku ... reseni ?
  • ? remove old_4_new - just for LSView
  • automatic preallocation
  • eliminated block given by IS
  • in place Schur
  • ? nemodifikovat puvodni system, leda skrze jeho metody
File sorption.hh
It seems that the methods isotherm_reinit() are different only at computation of scale_aqua and scale_sorbed. So it could be moved to SorptionDual and the only method which would be virtual would be compute_sorbing_scale(). It is prepared in comment code.
File sys_profiler.hh
  • START_GLOBAL_TIMER(tag) - this calls the start_timer, which creates local timer on the correct place in the hierarchy, further this timer is added to the list of global timers, this contains groups of timers with same tag, and collect/sum data from these timers in the report.
File sys_vector.hh
Implement co-located vector class that takes reference of the original Vector and is of the same size. FullIterator should have method for accessing elements in the original vector.
File transport.h
  • remove transport_sources
  • in create_transport_matric_mpi, there there is condition edge_flow > ZERO this makes matrix sparser, but can lead to elements without outflow and other problems when there are big differences in fluxes, more over it doesn't work if overall flow is very small
File xio.cc
Better error handling ( perror()? strerror()? )